From fb70b788bcbe77dcba0b16f2d529c9869032f6a5 Mon Sep 17 00:00:00 2001
From: Jonathan McCaffrey <jonmcc.0723@gmail.com>
Date: Mon, 18 Apr 2022 21:38:59 -0400
Subject: [PATCH] style(BuildCalc) Bank UI improvements and code cleanup

---
 .../BuildCalculator/Parts/BankComponent.razor |  38 ++-
 .../Parts/BuildChartComponent.razor           |   6 +-
 .../Parts/ChartComponent.razor                |   4 +-
 Model/Economy/EconomyModel.cs                 |   2 +-
 Services/IServices.cs                         |   2 +-
 Services/Immortal/BuildOrderService.cs        |   2 +-
 Services/Immortal/EconomyComparisonService.cs |   8 +-
 Services/Immortal/EconomyService.cs           | 217 +++++++++++-------
 8 files changed, 172 insertions(+), 107 deletions(-)

diff --git a/IGP/Pages/BuildCalculator/Parts/BankComponent.razor b/IGP/Pages/BuildCalculator/Parts/BankComponent.razor
index ec3fc18..b044b1f 100644
--- a/IGP/Pages/BuildCalculator/Parts/BankComponent.razor
+++ b/IGP/Pages/BuildCalculator/Parts/BankComponent.razor
@@ -5,7 +5,7 @@
 
 @implements IDisposable
 
-<FormLayoutComponent>
+<div class="bankContainer">
     <FormDisplayComponent Label="Time">
         <Display>@BuildOrderService.GetLastRequestInterval() | T @Interval.ToTime(BuildOrderService.GetLastRequestInterval())</Display>
     </FormDisplayComponent>
@@ -18,16 +18,42 @@
         </FormDisplayComponent>
     </div>
     <div class="bankRow">
-         <FormDisplayComponent Label="Pyre">
-             <Display>@economy.Pyre</Display>
-             </FormDisplayComponent>
+        <FormDisplayComponent Label="Pyre">
+            <Display>@economy.Pyre</Display>
+        </FormDisplayComponent>
         <FormDisplayComponent Label="Supply">
             <Display>@supplyTaken / @supplyGranted (@(supplyGranted / 16)@(extraBuildings > 0 ? "+" + extraBuildings : ""))</Display>
         </FormDisplayComponent>
     </div>
-</FormLayoutComponent>
+
+    <div>
+        <div class="workerText">Workers</div>
+        <div class="bankRow">
+            <FormDisplayComponent Label="Current">
+                <Display>@economy.WorkerCount</Display>
+            </FormDisplayComponent>
+            <FormDisplayComponent Label="Busy">
+                <Display>@economy.BusyWorkerCount</Display>
+            </FormDisplayComponent>
+            <FormDisplayComponent Label="Creating">
+                <Display>@economy.CreatingWorkerCount</Display>
+            </FormDisplayComponent>
+        </div>
+    </div>
+</div>
 
 <style>
+    .bankContainer {
+        display: flex;
+        flex-direction: column;
+        gap: 5px;
+    }
+    
+    .workerText {
+        margin-bottom: -2px;
+        font-size: 0.8em;
+    }
+
     .bankRow {
         display: flex;
         gap: 8px;
@@ -75,8 +101,6 @@
 
     void OnBuildOrderChanged()
     {
-        Console.WriteLine("OnBuildOrderChanged()");
-        
         economy = EconomyService.GetEconomy(BuildOrderService.GetLastRequestInterval());
 
         var ordersOverTime = BuildOrderService.GetOrders();
diff --git a/IGP/Pages/BuildCalculator/Parts/BuildChartComponent.razor b/IGP/Pages/BuildCalculator/Parts/BuildChartComponent.razor
index 79a8050..4448bd1 100644
--- a/IGP/Pages/BuildCalculator/Parts/BuildChartComponent.razor
+++ b/IGP/Pages/BuildCalculator/Parts/BuildChartComponent.razor
@@ -213,19 +213,19 @@ else
 
             var economyAtSecond = economyOverTime[interval];
 
-            var alloyWorkerHarvesters = from harvester in economyAtSecond.Harvesters
+            var alloyWorkerHarvesters = from harvester in economyAtSecond.HarvestPoints
                 where harvester.Harvest() != null
                 where harvester.Harvest().RequiresWorker
                 where harvester.Harvest().Resource == ResourceType.Alloy
                 select harvester;
 
-            var alloyAutomaticHarvesters = from harvester in economyAtSecond.Harvesters
+            var alloyAutomaticHarvesters = from harvester in economyAtSecond.HarvestPoints
                 where harvester.Harvest() != null
                 where harvester.Harvest().RequiresWorker == false
                 where harvester.Harvest().Resource == ResourceType.Alloy
                 select harvester;
 
-            var etherAutomaticHarvesters = from harvester in economyAtSecond.Harvesters
+            var etherAutomaticHarvesters = from harvester in economyAtSecond.HarvestPoints
                 where harvester.Harvest() != null
                 where harvester.Harvest().RequiresWorker == false
                 where harvester.Harvest().Resource == ResourceType.Ether
diff --git a/IGP/Pages/EconomyComparison/Parts/ChartComponent.razor b/IGP/Pages/EconomyComparison/Parts/ChartComponent.razor
index b6f079b..14d2b39 100644
--- a/IGP/Pages/EconomyComparison/Parts/ChartComponent.razor
+++ b/IGP/Pages/EconomyComparison/Parts/ChartComponent.razor
@@ -130,13 +130,13 @@
 
             var economyAtSecond = economyOverTime[interval];
 
-            var alloyWorkerHarvesters = from harvester in economyAtSecond.Harvesters
+            var alloyWorkerHarvesters = from harvester in economyAtSecond.HarvestPoints
                 where harvester.Harvest() != null
                 where harvester.Harvest().RequiresWorker
                 where harvester.Harvest().Resource == ResourceType.Alloy
                 select harvester;
 
-            var alloyAutomaticHarvesters = from harvester in economyAtSecond.Harvesters
+            var alloyAutomaticHarvesters = from harvester in economyAtSecond.HarvestPoints
                 where harvester.Harvest() != null
                 where harvester.Harvest().RequiresWorker == false
                 where harvester.Harvest().Resource == ResourceType.Alloy
diff --git a/Model/Economy/EconomyModel.cs b/Model/Economy/EconomyModel.cs
index b017184..b53f488 100644
--- a/Model/Economy/EconomyModel.cs
+++ b/Model/Economy/EconomyModel.cs
@@ -14,5 +14,5 @@ public class EconomyModel
     public int BusyWorkerCount { get; set; } = 0;
     public int CreatingWorkerCount { get; set; } = 0;
     public List<int> CreatingWorkerDelays { get; set; } = new();
-    public List<EntityModel> Harvesters { get; set; } = new();
+    public List<EntityModel> HarvestPoints { get; set; } = new();
 }
\ No newline at end of file
diff --git a/Services/IServices.cs b/Services/IServices.cs
index 5684b32..f232cb9 100644
--- a/Services/IServices.cs
+++ b/Services/IServices.cs
@@ -323,7 +323,7 @@ public interface IBuildOrderService
     public int? WillMeetSupply(EntityModel entity);
     public Dictionary<int, List<EntityModel>> GetOrders();
     public List<EntityModel> GetCompletedBefore(int interval);
-    public List<EntityModel> GetHarvestersCompletedBefore(int interval);
+    public List<EntityModel> GetHarvestPointsCompletedBefore(int interval);
 
     public void RemoveLast();
     public void Reset();
diff --git a/Services/Immortal/BuildOrderService.cs b/Services/Immortal/BuildOrderService.cs
index 1e317f9..5d624de 100644
--- a/Services/Immortal/BuildOrderService.cs
+++ b/Services/Immortal/BuildOrderService.cs
@@ -239,7 +239,7 @@ public class BuildOrderService : IBuildOrderService
             select orders).ToList();
     }
 
-    public List<EntityModel> GetHarvestersCompletedBefore(int interval)
+    public List<EntityModel> GetHarvestPointsCompletedBefore(int interval)
     {
         return (from ordersAtTime in buildOrder.StartedOrders
             from orders in ordersAtTime.Value
diff --git a/Services/Immortal/EconomyComparisonService.cs b/Services/Immortal/EconomyComparisonService.cs
index 1331ebc..6b2a959 100644
--- a/Services/Immortal/EconomyComparisonService.cs
+++ b/Services/Immortal/EconomyComparisonService.cs
@@ -93,7 +93,7 @@ public class EconomyComparisionService : IEconomyComparisonService
                 economyAtSecond.WorkerCount = buildEconomyOverTime[interval - 1].WorkerCount;
                 economyAtSecond.BusyWorkerCount = buildEconomyOverTime[interval - 1].BusyWorkerCount;
                 economyAtSecond.CreatingWorkerCount = buildEconomyOverTime[interval - 1].CreatingWorkerCount;
-                economyAtSecond.Harvesters = buildEconomyOverTime[interval - 1].Harvesters.ToList();
+                economyAtSecond.HarvestPoints = buildEconomyOverTime[interval - 1].HarvestPoints.ToList();
                 economyAtSecond.CreatingWorkerDelays = buildEconomyOverTime[interval - 1].CreatingWorkerDelays.ToList();
             }
 
@@ -103,7 +103,7 @@ public class EconomyComparisionService : IEconomyComparisonService
             float freeWorkers = economyAtSecond.WorkerCount - economyAtSecond.BusyWorkerCount;
             var workersNeeded = 0;
 
-            economyAtSecond.Harvesters =
+            economyAtSecond.HarvestPoints =
                 (from harvester in buildOrder.GetHarvestersCompletedBefore(interval)
                     select harvester).ToList();
 
@@ -111,7 +111,7 @@ public class EconomyComparisionService : IEconomyComparisonService
             economyAtSecond.Pyre += 1;
 
             // Add funds
-            foreach (var entity in economyAtSecond.Harvesters)
+            foreach (var entity in economyAtSecond.HarvestPoints)
             {
                 var harvester = entity.Harvest();
                 if (harvester.RequiresWorker)
@@ -185,7 +185,7 @@ public class EconomyComparisionService : IEconomyComparisonService
                 foreach (var newEntity in completedAtInterval)
                 {
                     var harvest = newEntity;
-                    if (harvest != null) economyAtSecond.Harvesters.Add(harvest);
+                    if (harvest != null) economyAtSecond.HarvestPoints.Add(harvest);
 
                     var production = newEntity.Production();
                     if (production != null && production.RequiresWorker) economyAtSecond.BusyWorkerCount -= 1;
diff --git a/Services/Immortal/EconomyService.cs b/Services/Immortal/EconomyService.cs
index 85ded3e..1b330bc 100644
--- a/Services/Immortal/EconomyService.cs
+++ b/Services/Immortal/EconomyService.cs
@@ -54,121 +54,162 @@ public class EconomyService : IEconomyService
             buildEconomyOverTime[interval] = new EconomyModel();
             
             var economyAtSecond = buildEconomyOverTime[interval];
-            if (interval > 0)
-            {
-                economyAtSecond.Alloy = buildEconomyOverTime[interval - 1].Alloy;
-                economyAtSecond.Ether = buildEconomyOverTime[interval - 1].Ether;
-                economyAtSecond.Pyre = buildEconomyOverTime[interval - 1].Pyre;
-                economyAtSecond.WorkerCount = buildEconomyOverTime[interval - 1].WorkerCount;
-                economyAtSecond.BusyWorkerCount = buildEconomyOverTime[interval - 1].BusyWorkerCount;
-                economyAtSecond.CreatingWorkerCount = buildEconomyOverTime[interval - 1].CreatingWorkerCount;
-                economyAtSecond.Harvesters = buildEconomyOverTime[interval - 1].Harvesters.ToList();
-                economyAtSecond.CreatingWorkerDelays = buildEconomyOverTime[interval - 1].CreatingWorkerDelays.ToList();
-            }
-
-            economyAtSecond.Interval = interval;
+            
+            CarryOverEconomyFromPreviousInterval(interval, economyAtSecond);
+
+            SetupCurrentInverval(buildOrder, economyAtSecond, interval);
+            AddPassivePyreGain(interval, economyAtSecond);
+            float freeWorkers = economyAtSecond.WorkerCount - economyAtSecond.BusyWorkerCount; 
+            var workersNeeded = AddFundsFromHarvestPoints(economyAtSecond, freeWorkers);
+            workersNeeded -= CalculateCreatingWorkerCosts(economyAtSecond);
+            MakeNeededNewWorkersRequests(workersNeeded, economyAtSecond);
+            SubtractFundsOnRequestedOrders(buildOrder, interval, economyAtSecond);
+            HandledAddingNewHarvestPointsAndWorkersToEconomy(buildOrder, interval, economyAtSecond);
+        }
 
-            // Add funds
-            float freeWorkers = economyAtSecond.WorkerCount - economyAtSecond.BusyWorkerCount;
-            var workersNeeded = 0;
+        NotifyDataChanged();
+    }
 
-            economyAtSecond.Harvesters =
-                (from harvester in buildOrder.GetHarvestersCompletedBefore(interval)
-                    select harvester).ToList();
+    private static void SetupCurrentInverval(IBuildOrderService buildOrder, EconomyModel economyAtSecond, int interval)
+    {
+        economyAtSecond.Interval = interval;
+        economyAtSecond.HarvestPoints =
+            (from harvester in buildOrder.GetHarvestPointsCompletedBefore(interval)
+                select harvester).ToList();
+    }
 
-            // Add funds
-            if (interval % 3 == 0)
+    private static void HandledAddingNewHarvestPointsAndWorkersToEconomy(IBuildOrderService buildOrder, int interval,
+        EconomyModel economyAtSecond)
+    {
+        if (buildOrder.CompletedOrders.TryGetValue(interval, out var completedAtInterval))
+            foreach (var newEntity in completedAtInterval)
             {
-                economyAtSecond.Pyre += 1;
+                var harvest = newEntity;
+                if (harvest != null) economyAtSecond.HarvestPoints.Add(harvest);
+
+                var production = newEntity.Production();
+                if (production != null && production.RequiresWorker) economyAtSecond.BusyWorkerCount -= 1;
             }
-            // Add funds
-            foreach (var entity in economyAtSecond.Harvesters)
-            {
-                var harvester = entity.Harvest();
-                if (harvester.RequiresWorker)
-                    if (harvester.Resource == ResourceType.Alloy)
-                    {
-                        var usedWorkers = Math.Min(harvester.Slots, freeWorkers);
-                        economyAtSecond.Alloy += harvester.HarvestedPerInterval * usedWorkers;
-                        freeWorkers -= usedWorkers;
+    }
 
-                        if (usedWorkers < harvester.Slots) workersNeeded += 1;
-                    }
+    private static void SubtractFundsOnRequestedOrders(IBuildOrderService buildOrder, int interval,
+        EconomyModel economyAtSecond)
+    {
+        if (buildOrder.StartedOrders.TryGetValue(interval, out var ordersAtTime))
+            foreach (var order in ordersAtTime)
+            {
+                var foundEntity = EntityModel.GetDictionary()[order.DataType];
+                var production = foundEntity.Production();
 
-                if (harvester.RequiresWorker == false)
+                if (production != null)
                 {
-                    if (harvester.Resource == ResourceType.Ether)
-                        economyAtSecond.Ether += harvester.HarvestedPerInterval * harvester.Slots;
+                    economyAtSecond.Alloy -= production.Alloy;
+                    economyAtSecond.Ether -= production.Ether;
+                    economyAtSecond.Pyre -= production.Pyre;
+                    var finishedAt = interval + production.BuildTime;
 
-                    if (harvester.Resource == ResourceType.Alloy)
-                        economyAtSecond.Alloy += harvester.HarvestedPerInterval * harvester.Slots;
+                    if (production.RequiresWorker) economyAtSecond.BusyWorkerCount += 1;
+
+                    if (production.ConsumesWorker) economyAtSecond.WorkerCount -= 1;
                 }
             }
+    }
 
-            // Create new worker
-            if (economyAtSecond.CreatingWorkerCount > 0)
-                for (var i = 0; i < economyAtSecond.CreatingWorkerDelays.Count; i++)
-                    if (economyAtSecond.CreatingWorkerDelays[i] > 0)
-                    {
-                        if (economyAtSecond.Alloy > 2.5f)
-                        {
-                            economyAtSecond.Alloy -= 2.5f;
-                            economyAtSecond.CreatingWorkerDelays[i]--;
-                        }
-                    }
-                    else
+    private static void MakeNeededNewWorkersRequests(int workersNeeded, EconomyModel economyAtSecond)
+    {
+        if (workersNeeded > economyAtSecond.CreatingWorkerCount)
+        {
+            economyAtSecond.CreatingWorkerCount += 1;
+            economyAtSecond.CreatingWorkerDelays.Add(20);
+        }
+    }
+
+    /**
+     * Returns amount of workers created
+     */
+    private static int CalculateCreatingWorkerCosts(EconomyModel economyAtSecond)
+    {
+        int createdWorkers = 0;
+        
+        if (economyAtSecond.CreatingWorkerCount > 0)
+            for (var i = 0; i < economyAtSecond.CreatingWorkerDelays.Count; i++)
+                if (economyAtSecond.CreatingWorkerDelays[i] > 0)
+                {
+                    if (economyAtSecond.Alloy > 2.5f)
                     {
-                        economyAtSecond.CreatingWorkerCount -= 1;
-                        economyAtSecond.WorkerCount += 1;
-                        economyAtSecond.CreatingWorkerDelays.Remove(i);
-                        i--;
+                        economyAtSecond.Alloy -= 2.5f;
+                        economyAtSecond.CreatingWorkerDelays[i]--;
                     }
+                }
+                else
+                {
+                    economyAtSecond.CreatingWorkerCount -= 1;
+                    economyAtSecond.WorkerCount += 1;
+                    createdWorkers++;
+                    economyAtSecond.CreatingWorkerDelays.Remove(i);
+                    i--;
+                }
 
-            if (workersNeeded > economyAtSecond.CreatingWorkerCount)
-            {
-                economyAtSecond.CreatingWorkerCount += 1;
-                economyAtSecond.CreatingWorkerDelays.Add(50);
-            }
-
-            // Remove Funds from Build Order
+        return createdWorkers;
+    }
 
-            if (buildOrder.StartedOrders.TryGetValue(interval, out var ordersAtTime))
-                foreach (var order in ordersAtTime)
+    /**
+     * Returns needed workers to maximize harvest points
+     */
+    private static int AddFundsFromHarvestPoints(EconomyModel economyAtSecond, float freeWorkers)
+    {
+        int workersNeeded = 0;
+        
+        foreach (var entity in economyAtSecond.HarvestPoints)
+        {
+            var harvester = entity.Harvest();
+            if (harvester.RequiresWorker)
+                if (harvester.Resource == ResourceType.Alloy)
                 {
-                    var foundEntity = EntityModel.GetDictionary()[order.DataType];
-                    var production = foundEntity.Production();
+                    var usedWorkers = Math.Min(harvester.Slots, freeWorkers);
+                    economyAtSecond.Alloy += harvester.HarvestedPerInterval * usedWorkers;
+                    freeWorkers -= usedWorkers;
 
-                    if (production != null)
-                    {
-                        economyAtSecond.Alloy -= production.Alloy;
-                        economyAtSecond.Ether -= production.Ether;
-                        economyAtSecond.Pyre -= production.Pyre;
-                        var finishedAt = interval + production.BuildTime;
+                    if (usedWorkers < harvester.Slots) workersNeeded += 1;
+                }
 
-                        if (production.RequiresWorker) economyAtSecond.BusyWorkerCount += 1;
+            if (harvester.RequiresWorker == false)
+            {
+                if (harvester.Resource == ResourceType.Ether)
+                    economyAtSecond.Ether += harvester.HarvestedPerInterval * harvester.Slots;
 
-                        if (production.ConsumesWorker) economyAtSecond.WorkerCount -= 1;
-                    }
-                }
+                if (harvester.Resource == ResourceType.Alloy)
+                    economyAtSecond.Alloy += harvester.HarvestedPerInterval * harvester.Slots;
+            }
+        }
 
-            // Handle new entities
-            if (buildOrder.CompletedOrders.TryGetValue(interval, out var completedAtInterval))
-                foreach (var newEntity in completedAtInterval)
-                {
-                    var harvest = newEntity;
-                    if (harvest != null) economyAtSecond.Harvesters.Add(harvest);
+        return workersNeeded;
+    }
 
-                    var production = newEntity.Production();
-                    if (production != null && production.RequiresWorker) economyAtSecond.BusyWorkerCount -= 1;
-                }
+    private static void AddPassivePyreGain(int interval, EconomyModel economyAtSecond)
+    {
+        if (interval % 3 == 0)
+        {
+            economyAtSecond.Pyre += 1;
         }
+    }
 
-        NotifyDataChanged();
+    private void CarryOverEconomyFromPreviousInterval(int interval, EconomyModel economyAtSecond)
+    {
+        if (interval > 0)
+        {
+            economyAtSecond.Alloy = buildEconomyOverTime[interval - 1].Alloy;
+            economyAtSecond.Ether = buildEconomyOverTime[interval - 1].Ether;
+            economyAtSecond.Pyre = buildEconomyOverTime[interval - 1].Pyre;
+            economyAtSecond.WorkerCount = buildEconomyOverTime[interval - 1].WorkerCount;
+            economyAtSecond.BusyWorkerCount = buildEconomyOverTime[interval - 1].BusyWorkerCount;
+            economyAtSecond.CreatingWorkerCount = buildEconomyOverTime[interval - 1].CreatingWorkerCount;
+            economyAtSecond.HarvestPoints = buildEconomyOverTime[interval - 1].HarvestPoints.ToList();
+            economyAtSecond.CreatingWorkerDelays = buildEconomyOverTime[interval - 1].CreatingWorkerDelays.ToList();
+        }
     }
 
 
-    
-    
     public EconomyModel GetEconomy(int atInterval)
     {
         if (atInterval >= buildEconomyOverTime.Count) return buildEconomyOverTime.Last();