240 lines
29 KiB
Markdown
240 lines
29 KiB
Markdown
---
|
||
sessionId: session-260928-112553-atgt
|
||
---
|
||
|
||
# Requirements
|
||
|
||
### Overview & Goals
|
||
Manually clicking a save button after every map modification introduces recurring cognitive friction, slows down editing workflows, and creates a risk of lost progress if the application closes unexpectedly. Automating the persistence layer eliminates redundant user effort, optimizes editing efficiency, and ensures maximum utility by immediately guaranteeing that every map node movement or property adjustment is reliably written to disk without requiring explicit manual intervention.
|
||
|
||
### Scope
|
||
- **In Scope**:
|
||
- Automatically persisting modified system coordinates when node dragging finishes (`OnPointerReleased`).
|
||
- Automatically persisting modified coordinates with a debounce delay when typing in the Inspector's X and Y text entries (`OnPositionTextChanged`).
|
||
- Auto-saving newly assigned placeholder positions when loading folders containing star systems without coordinates.
|
||
- Updating toolbar elements and status labels to provide real-time save state feedback ("Saved", "Saving...", "All changes saved") rather than relying on a required manual "Save" button.
|
||
- Ensuring background/asynchronous file writes or safe dispatcher execution so the UI remains fluid and uninterrupted.
|
||
- **Out of Scope**:
|
||
- Modifying the underlying frontmatter format parsed by `StarSystemDocStore`.
|
||
- Adding undo/redo history stack (can be addressed as a separate productivity enhancement).
|
||
- File system watching for external file modifications outside the editor.
|
||
|
||
### User Stories
|
||
- As a map designer, I want my node movements and coordinate edits to save automatically to the underlying Markdown documents, so that I can focus entirely on layout without worrying about saving or losing progress.
|
||
- As an editor user, I want subtle, immediate visual feedback confirming that my changes have been successfully persisted, so that I have complete confidence in the integrity of my work.
|
||
|
||
### Functional Requirements
|
||
- **Drag-and-Drop Auto-Save**: When a user drags one or more star systems and releases the pointer, all dirty nodes in the selection must automatically trigger a persistence pass to `StarSystemDocStore.SavePositions`.
|
||
- **Debounced Inspector Entry Auto-Save**: When a user modifies X or Y coordinates directly in the Inspector text boxes, the change must automatically save after a brief pause (e.g. 300–500ms debounce), preventing excessive disk I/O on every single keystroke while ensuring prompt persistence.
|
||
- **Auto-Save on Initial Layout Assignment**: When loading documents missing coordinates (`!HasPosition`), placeholder coordinates assigned by `DefaultPosition` must be auto-persisted.
|
||
- **Non-Intrusive Status Feedback**: Status messages must indicate when changes are being saved and confirm successful persistence ("All changes saved" / "Auto-saved N system(s)"), gracefully updating without blocking canvas interactions.
|
||
- **Toolbar Streamlining**: The previous manual "Save" button will be repurposed or streamlined into a status indicator / optional manual sync trigger that reflects clean save states.
|
||
|
||
### Non-Functional Requirements
|
||
- **Efficiency & Utility**: Debounced I/O minimizes unnecessary disk writes and prevents UI hitching during rapid user input.
|
||
- **Fault Tolerance**: File write failures (e.g. read-only files or transient file locks) must be caught safely and reported via status messages without crashing the editor.
|
||
- **Platform Compatibility**: Works identically across Windows WinUI desktop and MacCatalyst environments.
|
||
|
||
---
|
||
|
||
# Technical Design
|
||
|
||
### Current Implementation
|
||
- `ZeroSpace.MapEditor.Views.MapEditorPage`:
|
||
- Maintains `_nodes` and `_selectedNodes`. Dragging updates `node.X`, `node.Y`, and sets `node.Doc.IsDirty = true`.
|
||
- `OnPositionTextChanged` updates `_selected.X`, `_selected.Y`, and sets `node.Doc.IsDirty = true`.
|
||
- `OnSaveClicked` explicitly calls `StarSystemDocStore.SavePositions(_nodes.Select(static node => node.Doc))`.
|
||
- `UpdateDirtyState` enables/disables `SaveButton` and updates `StatusLabel` with "N unsaved position change(s)".
|
||
- `ZeroSpace.MapEditor.Services.StarSystemDocStore`:
|
||
- `SavePositions(IEnumerable<StarSystemDoc> docs)` iterates through dirty documents, rewrites the YAML frontmatter `x:` and `y:` lines preserving byte formatting, and clears `IsDirty = false`.
|
||
|
||
### Key Decisions
|
||
1. **Debounced Timer for Text Input vs Immediate on Pointer Release**:
|
||
- *Decision*: Trigger auto-save immediately on `OnPointerReleased` when dragging has occurred, and use a lightweight debounced timer (`IDispatcherTimer` or `CancellationTokenSource` task delay) of ~400ms for `OnPositionTextChanged`.
|
||
- *Rationale*: Releasing a drag gesture is a discrete user milestone where immediate disk write gives instant safety. Typing numbers is continuous, where a 400ms debounce prevents intermediate invalid or half-typed states from generating excessive disk writes while still guaranteeing persistence within a fraction of a second.
|
||
2. **Safe Background & Error Handling**:
|
||
- *Decision*: Wrap save operations in robust exception handling and perform file operations asynchronously or off the main thread if needed, updating the UI status seamlessly.
|
||
- *Rationale*: Eliminates the risk of application crashes due to transient file access locks and preserves high UI framerates during continuous editing.
|
||
3. **Save Button Repurposing**:
|
||
- *Decision*: Update the Save button to either act as an optional instant-flush control or transition it into a save status badge.
|
||
- *Rationale*: Maximizes utility for users who want visual confirmation or immediate flushing while removing the burden of mandatory manual saving.
|
||
|
||
### Proposed Changes
|
||
|
||
#### 1. Add Auto-Save Controller / Debounce Logic to `MapEditorPage.xaml.cs`
|
||
- Add a debounce mechanism for text input (e.g. `CancellationTokenSource? _autoSaveCts` or `IDispatcherTimer`).
|
||
- Create `ScheduleAutoSave()` and `ExecuteAutoSaveAsync()` methods.
|
||
- In `OnPointerReleased`: if `_draggingNode` was active and nodes moved, trigger auto-save immediately.
|
||
- In `OnPositionTextChanged`: if values changed, schedule debounced auto-save.
|
||
- In `LoadFolder`: after loading docs and assigning missing positions, execute auto-save to persist initial coordinates.
|
||
|
||
#### 2. Update `Views/MapEditorPage.xaml` & Status Feedback
|
||
- Update toolbar: `SaveButton` can display "Saved" (disabled/subtle) or "Saving..." while persisting, and remain clickable for manual force-save if desired.
|
||
- Status label updates to reflect "Auto-saved at [time]" or "All changes saved to [folder]".
|
||
|
||
### Components
|
||
- `MapEditorPage` (`Views/MapEditorPage.xaml.cs`): Orchestrates drag/text events, schedules debounced persistence, and updates status UI.
|
||
- `StarSystemDocStore` (`Services/StarSystemDocStore.cs`): Executes thread-safe, atomic-preserving frontmatter file writes for dirty documents.
|
||
|
||
### File Structure
|
||
```
|
||
ZeroSpace/ZeroSpace.MapEditor/
|
||
├── Services/
|
||
│ └── StarSystemDocStore.cs [File persistence logic]
|
||
└── Views/
|
||
├── MapEditorPage.xaml [Toolbar & Inspector UI]
|
||
└── MapEditorPage.xaml.cs [Auto-save orchestration & event handlers]
|
||
```
|
||
|
||
### Architecture Diagram
|
||
```mermaid
|
||
graph TD
|
||
subgraph UserInteractions["User Interaction Triggers"]
|
||
DragRelease["Pointer Released (Drag End)"] -->|Immediate Trigger| AutoSaveEngine["Auto-Save Orchestrator"]
|
||
TextEntry["Inspector X/Y Entry Changed"] -->|400ms Debounce| AutoSaveEngine
|
||
FolderLoad["Folder Loaded (Missing Coords)"] -->|Post-Layout Trigger| AutoSaveEngine
|
||
end
|
||
|
||
subgraph AutoSaveEngine["Persistence Layer (MapEditorPage)"]
|
||
AutoSaveEngine -->|Query Dirty Docs| DocFilter["Filter node.Doc.IsDirty == true"]
|
||
DocFilter -->|Write Frontmatter| Store["StarSystemDocStore.SavePositions()"]
|
||
Store -->|Clear IsDirty & Update UI| StatusUI["StatusLabel & Toolbar Feedback"]
|
||
end
|
||
|
||
subgraph FileSystem["Disk Storage"]
|
||
Store -->|Write Frontmatter YAML| MarkdownFiles["zs.docs/StarSystem/*.md"]
|
||
end
|
||
```
|
||
|
||
### Risks & Mitigations
|
||
- **Risk**: Rapid typing in X/Y fields creating concurrent or conflicted file writes.
|
||
- *Mitigation*: Debounce timer cancels previous pending save passes, ensuring only the latest coordinate value is written once typing pauses.
|
||
- **Risk**: File lock or permission error during background auto-save interrupting the user.
|
||
- *Mitigation*: Gracefully catch `IOException` / `UnauthorizedAccessException`, update status label with descriptive warning ("Auto-save failed: ..."), and retain `IsDirty = true` so subsequent passes retry automatically.
|
||
|
||
---
|
||
|
||
# Testing
|
||
|
||
### Validation Approach
|
||
Verification will be conducted using automated build verification on the .NET SDK and unit/integration testing of the debounced persistence flow and frontmatter updater.
|
||
|
||
### Key Scenarios
|
||
1. **Drag-and-Drop Auto-Persistence**:
|
||
- Move a map node via canvas drag and release pointer.
|
||
- Verify document frontmatter `x:` and `y:` values in `zs.docs/StarSystem/*.md` update on disk without clicking Save.
|
||
2. **Inspector Entry Debounce Persistence**:
|
||
- Type new coordinate values into `XEntry` or `YEntry`.
|
||
- Verify that after the debounce period (400ms), dirty status clears and file content on disk matches the new input values.
|
||
3. **Multi-Node Auto-Save**:
|
||
- Marquee-select multiple nodes and drag them simultaneously.
|
||
- Verify all moved nodes are saved with updated coordinates in their respective markdown files.
|
||
4. **Missing Coordinates Auto-Save**:
|
||
- Load a folder containing documents without `x` / `y` properties.
|
||
- Verify default generated coordinates are automatically persisted.
|
||
|
||
### Edge Cases
|
||
- **Rapid Successive Changes**: Repeated fast drags and typing bursts do not produce race conditions or corrupt file contents.
|
||
- **Read-Only / Locked Files**: Handled cleanly with user notification and automatic dirty state preservation for subsequent retry.
|
||
|
||
# Delivery Steps
|
||
|
||
### ✓ Step 1: Implementation
|
||
<plan_session_history>
|
||
History processor: During the current session, you have worked on the following `<previous_issue>`.
|
||
The `<issue_description>` usually continues or extends your previous work. Consider all `<previous_issue>` and `<issue_description>` together.
|
||
If `<assistant_question>`/`<user_answer>` blocks are present, treat them as additional user-provided context that may contain important clarifications about the task.
|
||
<previous_issue>
|
||
## Plan Task
|
||
Make the ZeroSpace.MapEditor project work on Windows PC
|
||
</previous_issue>
|
||
<previous_issue_solution>
|
||
tool name: submit
|
||
tool parameters:
|
||
- "delivery_plan"=[{"description":"The `ZeroSpace.MapEditor.csproj` file contains all necessary SDK references, target framework settings, and unpackaged WinUI configuration to target Windows desktop.\n\n- Update `ZeroSpace/ZeroSpace.MapEditor/ZeroSpace.MapEditor.csproj` to conditionally set `TargetFrameworks` (`net10.0-windows10.0.19041.0` on Windows, `net10.0-maccatalyst` on other platforms).\n- Add package reference `<PackageReference Include=\"Microsoft.Maui.Controls\" Version=\"$(MauiVersion)\" />`.\n- Set `<WindowsPackageType>None</WindowsPackageType>` to enable unpackaged desktop execution without MSIX signing requirements.\n- Set `<SupportedOSPlatformVersion>` and `<TargetPlatformMinVersion>` for Windows to `10.0.17763.0`.\n- Retain existing MAUI asset items (fonts, images) and ensure consistent single-project asset routing.","name":"Configure ZeroSpace.MapEditor project file and package references"},{"description":"The `Platforms/Windows/` folder contains the required WinUI 3 application bootstrap and manifest files.\n\n- Create `ZeroSpace/ZeroSpace.MapEditor/Platforms/Windows/App.xaml` declaring the `MauiWinUIApplication` root with `x:Class=\"ZeroSpace.MapEditor.WinUI.App\"`.\n- Create `ZeroSpace/ZeroSpace.MapEditor/Platforms/Windows/App.xaml.cs` initializing the WinUI application and overriding `CreateMauiApp()` to invoke `MauiProgram.CreateMauiApp()`.\n- Create `ZeroSpace/ZeroSpace.MapEditor/Platforms/Windows/app.manifest` configuring DPI awareness (PerMonitorV2) and long-path support.\n- Ensure cross-platform compatibility files in `Platforms/MacCatalyst/` (`AppDelegate.cs`, `Info.plist`, `Program.cs`) remain cleanly separated and intact.","name":"Add Windows platform host entry point and application manifests"},{"name":"Validate Windows build and map editor functionality","description":"The `ZeroSpace.MapEditor` project compiles cleanly on Windows and correctly loads star systems from `zs.docs/StarSystem`.\n\n- Build `ZeroSpace.MapEditor` targeting `net10.0-windows10.0.19041.0` using `dotnet build ZeroSpace\\ZeroSpace.MapEditor\\ZeroSpace.MapEditor.csproj`.\n- Verify the solution build in `ZeroSpace\\ZeroSpace.sln` completes without errors or missing reference warnings.\n- Validate that `MapEditorPage.xaml.cs` runtime directory resolution (`TryAutoLoad` and folder picker) successfully resolves the `zs.docs\\StarSystem` markdown star system files."}],
|
||
- "name"="make-map-editor-work-on-windows",
|
||
- "proposal"=[{"name":"Requirements","content":"### Overview & Goals\nThe `ZeroSpace.MapEditor` project is a .NET MAUI desktop tool intended for editing galactic war star systems and celestial maps backed by Markdown frontmatter in the `zs.docs` repository folder. Currently, the project lacks Windows platform configuration and host files, preventing it from compiling and launching on a Windows PC. The goal of this change is to configure `ZeroSpace.MapEditor` so it builds and runs smoothly on Windows desktop as an unpackaged WinUI application.\n\n### Scope\n- **In Scope**:\n - Updating `ZeroSpace/ZeroSpace.MapEditor/ZeroSpace.MapEditor.csproj` to include Windows target framework (`net10.0-windows10.0.19041.0`), `<WindowsPackageType>None</WindowsPackageType>`, and the required `Microsoft.Maui.Controls` package reference.\n - Adding WinUI 3 host bootstrap files in `Platforms/Windows/` (`App.xaml`, `App.xaml.cs`, `app.manifest`).\n - Ensuring the application can be built and launched with `dotnet run` / Rider on Windows without MSIX package signing hurdles.\n - Verifying compatibility of the existing file loading (`zs.docs/StarSystem`) and UI rendering on Windows desktop.\n- **Out of Scope**:\n - Modifying the core map editing business logic or parser in `MapEditorPage.xaml.cs`.\n - MSIX store packaging or code signing pipelines.\n - Changes to other projects in the solution (`ZeroSpace.Web`, `ZeroSpace.ApiService`, etc.).\n\n### User Stories\n- As a developer on Windows, I want to compile and launch `ZeroSpace.MapEditor` directly using `dotnet run` or JetBrains Rider, so that I can edit star system maps without switching operating systems.\n- As a map designer, I want the map editor on Windows to automatically locate the repository's `zs.docs/StarSystem` folder and permit folder picking, so that I can inspect and edit star system nodes.\n\n### Functional Requirements\n- `ZeroSpace.MapEditor` must compile successfully on Windows PC targeting `net10.0-windows10.0.19041.0`.\n- Launching the app on Windows must display the `MapEditorPage` with full interactive canvas rendering (drawing star systems, nodes, and connections).\n- Auto-loading of star systems (`TryAutoLoad`) must correctly locate `zs.docs\\StarSystem` when traversing upward from the Windows execution directory.\n- The folder picker dialog must function on Windows desktop when browsing for custom directories.\n\n### Non-Functional Requirements\n- **Build Performance**: Fast incremental build without requiring external Mac/iOS workloads when building on Windows.\n- **Packaging Simplicity**: Uses unpackaged desktop mode (`WindowsPackageType=None`) so no MSIX developer certs or installation steps are necessary.\n- **Clean Architecture**: Follows standard .NET MAUI single-project structure with platform-specific code isolated under `Platforms/`.\n"},{"name":"Technical Design","content":"### Current Implementation\nThe `ZeroSpace.MapEditor` project currently consists of:\n- `ZeroSpace.MapEditor.csproj`: A basic MAUI project file targeting `net10.0-maccatalyst17.0` and `net10.0-windows10.0.19041.0`, but missing the `<PackageReference Include=\"Microsoft.Maui.Controls\" Version=\"$(MauiVersion)\" />` package reference and `<WindowsPackageType>None</WindowsPackageType>`.\n- `App.xaml` & `App.xaml.cs`: MAUI application markup and code-behind.\n- `MauiProgram.cs`: MAUI app builder configuring fonts (`OpenSans-Regular`, `OpenSans-Semibold`).\n- `MapEditorPage.xaml` & `MapEditorPage.xaml.cs`: Canvas-based map rendering and Markdown parser for star system documents.\n- `Platforms/MacCatalyst/`: Contains `AppDelegate.cs`, `Info.plist`, and `Program.cs`.\n- `Platforms/Windows/`: **Missing entirely**. WinUI 3 requires `MauiWinUIApplication` in `App.xaml` / `App.xaml.cs` and an `app.manifest`.\n\n### Key Decisions\n1. **Unpackaged WinUI Application (`WindowsPackageType=None`)**:\n - *Decision*: Configure `ZeroSpace.MapEditor` as an unpackaged desktop application.\n - *Rationale*: Packaged MSIX applications require signing certificates, package deployment registration, and virtualized file system redirection that can complicate accessing repo-relative markdown files. Unpackaged mode allows direct standard `.exe` execution and simple `dotnet run` workflows.\n2. **Conditional Target Frameworks**:\n - *Decision*: Target `net10.0-windows10.0.19041.0` when building on Windows (`$([MSBuild]::IsOSPlatform('windows'))`) and `net10.0-maccatalyst` on non-Windows.\n - *Rationale*: Prevents build failures or warnings on Windows when Mac/iOS workloads or SDKs are not installed, while preserving cross-platform developer support.\n3. **WinUI Application Host Class in `Platforms/Windows/`**:\n - *Decision*: Add `Platforms/Windows/App.xaml` and `Platforms/Windows/App.xaml.cs` inheriting from `MauiWinUIApplication` in namespace `ZeroSpace.MapEditor.WinUI`.\n - *Rationale*: Standard WinUI 3 entry point required by .NET MAUI to host the WinUI application lifecycle on Windows.\n\n### Proposed Changes\n\n#### 1. Update `ZeroSpace.MapEditor.csproj`\n```xml\n<Project Sdk=\"Microsoft.NET.Sdk\">\n\n\t<PropertyGroup>\n\t\t<TargetFrameworks Condition=\"$([MSBuild]::IsOSPlatform('windows'))\">net10.0-windows10.0.19041.0</TargetFrameworks>\n\t\t<TargetFrameworks Condition=\"!$([MSBuild]::IsOSPlatform('windows'))\">net10.0-maccatalyst</TargetFrameworks>\n\t\t<OutputType>Exe</OutputType>\n\t\t<RootNamespace>ZeroSpace.MapEditor</RootNamespace>\n\t\t<UseMaui>true</UseMaui>\n\t\t<SingleProject>true</SingleProject>\n\t\t<ImplicitUsings>enable</ImplicitUsings>\n\t\t<Nullable>enable</Nullable>\n\n\t\t<ApplicationTitle>ZeroSpace Map Editor</ApplicationTitle>\n\t\t<ApplicationId>ca.jonathanmccaffrey.zerospace.mapeditor</ApplicationId>\n\t\t<ApplicationDisplayVersion>1.0</ApplicationDisplayVersion>\n\t\t<ApplicationVersion>1</ApplicationVersion>\n\n\t\t<!-- Unpackaged Windows desktop execution -->\n\t\t<WindowsPackageType>None</WindowsPackageType>\n\n\t\t<SupportedOSPlatformVersion Condition=\"$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'\">10.0.17763.0</SupportedOSPlatformVersion>\n\t\t<TargetPlatformMinVersion Condition=\"$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'windows'\">10.0.17763.0</TargetPlatformMinVersion>\n\t</PropertyGroup>\n\n\t<ItemGroup>\n\t\t<PackageReference Include=\"Microsoft.Maui.Controls\" Version=\"$(MauiVersion)\" />\n\t</ItemGroup>\n\n</Project>\n```\n\n#### 2. Add `Platforms/Windows/App.xaml`\n```xml\n<maui:MauiWinUIApplication\n x:Class=\"ZeroSpace.MapEditor.WinUI.App\"\n xmlns=\"http://schemas.microsoft.com/winfx/2006/xaml/presentation\"\n xmlns:x=\"http://schemas.microsoft.com/winfx/2006/xaml\"\n xmlns:maui=\"using:Microsoft.Maui\"\n xmlns:local=\"using:ZeroSpace.MapEditor.WinUI\">\n\n</maui:MauiWinUIApplication>\n```\n\n#### 3. Add `Platforms/Windows/App.xaml.cs`\n```csharp\nusing Microsoft.UI.Xaml;\n\nnamespace ZeroSpace.MapEditor.WinUI;\n\npublic partial class App : MauiWinUIApplication\n{\n\tpublic App()\n\t{\n\t\tthis.InitializeComponent();\n\t}\n\n\tprotected override MauiApp CreateMauiApp() => MauiProgram.CreateMauiApp();\n}\n```\n\n#### 4. Add `Platforms/Windows/app.manifest`\n```xml\n<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<assembly manifestVersion=\"1.0\" xmlns=\"urn:schemas-microsoft-com:asm.v1\">\n <assemblyIdentity version=\"1.0.0.0\" name=\"ZeroSpace.MapEditor.WinUI.app\"/>\n <application xmlns=\"urn:schemas-microsoft-com:asm.v3\">\n <windowsSettings>\n <dpiAware xmlns=\"http://schemas.microsoft.com/SMI/2005/WindowsSettings\">true/PM</dpiAware>\n <dpiAwareness xmlns=\"http://schemas.microsoft.com/SMI/2016/WindowsSettings\">PerMonitorV2, PerMonitor</dpiAwareness>\n <longPathAware xmlns=\"http://schemas.microsoft.com/SMI/2016/WindowsSettings\">true</longPathAware>\n </windowsSettings>\n </application>\n</assembly>\n```\n\n### File Structure\n```\nZeroSpace/ZeroSpace.MapEditor/\n├── App.xaml\n├── App.xaml.cs\n├── AppShell.xaml (if added)\n├── MauiProgram.cs\n├── MapEditorPage.xaml\n├── MapEditorPage.xaml.cs\n├── ZeroSpace.MapEditor.csproj [Modified]\n├── Platforms/\n│ ├── MacCatalyst/\n│ │ ├── AppDelegate.cs\n│ │ ├── Info.plist\n│ │ └── Program.cs\n│ └── Windows/ [New Directory]\n│ ├── App.xaml [New File]\n│ ├── App.xaml.cs [New File]\n│ └── app.manifest [New File]\n└── Resources/\n ├── AppIcon/\n ├── Fonts/\n ├── Images/\n ├── Raw/\n └── Splash/\n```\n\n### Architecture Diagram\n```mermaid\ngraph TD\n subgraph WindowsDesktop[\"Windows Desktop Host\"]\n WinExe[\"ZeroSpace.MapEditor.exe\"] --> WinApp[\"Platforms/Windows/App (MauiWinUIApplication)\"]\n end\n\n subgraph MauiCore[\"MAUI Shared Layer\"]\n WinApp --> MauiProg[\"MauiProgram.CreateMauiApp()\"]\n MauiProg --> App[\"App.xaml.cs\"]\n App --> MapEditorPage[\"MapEditorPage.xaml.cs (Canvas & Editor)\"]\n end\n\n subgraph DataStorage[\"File System (zs.docs)\"]\n MapEditorPage -->|TryAutoLoad / FolderPicker| DocsFolder[\"zs.docs/StarSystem/*.md\"]\n end\n```\n\n### Risks & Mitigations\n- **Risk**: Missing Windows SDK or WinUI workload components on the development machine.\n - *Mitigation*: The project targets `net10.0-windows10.0.19041.0` and references standard `Microsoft.Maui.Controls` which is already included in .NET MAUI SDK on Windows.\n- **Risk**: Path separator differences when parsing star system markdown files on Windows (`\\` vs `/`).\n - *Mitigation*: `MapEditorPage.xaml.cs` utilizes `Path.Combine` and `Directory.GetParent`, which natively handle Windows directory separators.\n"},{"content":"### Validation Approach\nVerification will be performed by building the project with the .NET SDK / MSBuild and testing the map editor loading flow on Windows desktop.\n\n### Key Scenarios\n1. **Clean Project Compilation**:\n - Run `dotnet build ZeroSpace\\ZeroSpace.MapEditor\\ZeroSpace.MapEditor.csproj -f net10.0-windows10.0.19041.0`.\n - Verify build completes with 0 errors and 0 warnings.\n2. **Solution Build Compatibility**:\n - Run `dotnet build ZeroSpace\\ZeroSpace.sln`.\n - Verify all projects in the solution build cleanly together.\n3. **Star System Auto-Loading on Windows**:\n - Verify `TryAutoLoad()` in `MapEditorPage.xaml.cs` resolves `zs.docs\\StarSystem` from the project's bin directory on Windows without throwing `DirectoryNotFoundException`.\n4. **Desktop UI Window Launch**:\n - Verify the application initializes the main window and renders the star system graph canvas.\n\n### Edge Cases\n- **Missing MacCatalyst Workload on Windows**: Verify that building on Windows does not attempt to compile the MacCatalyst target or fail due to missing Apple SDKs.\n- **Long Path Names in `zs.docs`**: Verify `app.manifest` enables `longPathAware` so long file paths in `zs.docs` are supported without truncation.\n","name":"Testing"}]
|
||
</previous_issue_solution>
|
||
<previous_issue>
|
||
## Orchestrated Plan Task
|
||
implement according to the plan
|
||
</previous_issue>
|
||
<previous_issue_solution>
|
||
### Summary
|
||
- Enabled `ZeroSpace.MapEditor` to build for Windows as an unpackaged .NET MAUI WinUI app and completed the planned Windows host setup.
|
||
- Resolved remaining Windows compatibility blockers so the project and full solution now build cleanly on Windows.
|
||
|
||
### Changes
|
||
- Updated `ZeroSpace.MapEditor.csproj` with conditional Windows/Mac target frameworks, `WindowsPackageType=None`, Windows min/supported OS versions, and required MAUI/CommunityToolkit package references.
|
||
- Added `Platforms/Windows/App.xaml`, `App.xaml.cs`, and `app.manifest` for the WinUI host bootstrap, DPI awareness, and long-path support.
|
||
- Fixed Windows build blockers by switching app startup to `CreateWindow(...)` and wiring folder picking through `CommunityToolkit.Maui.Storage` in `MapEditorPage.xaml.cs`.
|
||
|
||
### Verification
|
||
- Verified `dotnet build ZeroSpace\ZeroSpace.MapEditor\ZeroSpace.MapEditor.csproj -f net10.0-windows10.0.19041.0` succeeds with 0 warnings and 0 errors.
|
||
- Verified `dotnet build ZeroSpace\ZeroSpace.sln` succeeds with 0 warnings and 0 errors; confirmed `TryAutoLoad` upward traversal reaches `zs.docs\StarSystem` from the Windows build output path.
|
||
|
||
### Notes
|
||
- GUI launch/canvas interaction and live folder-picker interaction were not exercised in this headless environment, but the produced Windows build is clean and the path-resolution logic was independently confirmed.
|
||
</previous_issue_solution>
|
||
<previous_issue>
|
||
## Plan Task
|
||
System.TypeLoadException: Method 'get_HasExplicitSafeAreaEdges' in type 'Microsoft.Maui.Controls.Page' from assembly 'Microsoft.Maui.Controls, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
|
||
at Microsoft.Maui.Controls.Hosting.AppHostBuilderExtensions.RemapForControls(MauiAppBuilder builder)
|
||
at Microsoft.Maui.Controls.Hosting.AppHostBuilderExtensions.RemapForControls(MauiAppBuilder builder)
|
||
at Microsoft.Maui.Controls.Hosting.AppHostBuilderExtensions.SetupDefaults(MauiAppBuilder builder)
|
||
at Microsoft.Maui.Controls.Hosting.AppHostBuilderExtensions.UseMauiPrimaryApp[TApp](MauiAppBuilder builder)
|
||
at Microsoft.Maui.Controls.Hosting.AppHostBuilderExtensions.UseMauiApp[TApp](MauiAppBuilder builder)
|
||
at ZeroSpace.MapEditor.MauiProgram.CreateMauiApp() in C:\Users\jonmc\ZeroSpace\ZeroSpace\ZeroSpace.MapEditor\MauiProgram.cs:line 8
|
||
at ZeroSpace.MapEditor.WinUI.App.CreateMauiApp() in C:\Users\jonmc\ZeroSpace\ZeroSpace\ZeroSpace.MapEditor\Platforms\Windows\App.xaml.cs:line 12
|
||
at Microsoft.Maui.MauiWinUIApplication.OnLaunched(LaunchActivatedEventArgs args)
|
||
at Microsoft.UI.Xaml.Application.Microsoft.UI.Xaml.IApplicationOverrides.OnLaunched(LaunchActivatedEventArgs args)
|
||
at ABI.Microsoft.UI.Xaml.IApplicationOverrides.Do_Abi_OnLaunched_0(IntPtr thisPtr, IntPtr args)
|
||
</previous_issue>
|
||
<previous_issue_solution>
|
||
tool name: submit
|
||
tool parameters:
|
||
</previous_issue_solution>
|
||
<previous_issue>
|
||
## Orchestrated Plan Task
|
||
implement according to the plan
|
||
</previous_issue>
|
||
<previous_issue>
|
||
## Plan Task
|
||
Add a search feature to the editor that will highlight matching nodes in the ZeroSpace.MapEditor
|
||
</previous_issue>
|
||
<previous_issue_solution>
|
||
tool name: submit
|
||
tool parameters:
|
||
</previous_issue_solution>
|
||
<previous_issue>
|
||
## Orchestrated Plan Task
|
||
implement according to the plan
|
||
</previous_issue>
|
||
<previous_issue_solution>
|
||
### Summary
|
||
- Implemented the ZeroSpace.MapEditor search feature so users can search star systems by name and visually highlight matching nodes on the map.
|
||
- Added live search behavior plus search-submit navigation to the first match, while keeping the Windows build and full solution build clean.
|
||
|
||
### Changes
|
||
- Added `IsHighlighted` state to `Models/MapNode.cs` and updated `Views/MapDrawable.cs` to render a gold highlight ring while preserving a distinct selection ring.
|
||
- Added a `SearchBar` to `Views/MapEditorPage.xaml` and wired `TextChanged` / `SearchButtonPressed` events.
|
||
- Implemented search application, status updates, first-match focus, viewport centering, and search reapplication on folder reload in `Views/MapEditorPage.xaml.cs`.
|
||
|
||
### Verification
|
||
- Verified `dotnet build ZeroSpace\ZeroSpace.MapEditor\ZeroSpace.MapEditor.csproj -f net10.0-windows10.0.19041.0` succeeds with 0 warnings and 0 errors.
|
||
- Verified `dotnet build ZeroSpace\ZeroSpace.sln` succeeds with 0 warnings and 0 errors; reviewer found no blocking issues.
|
||
|
||
### Notes
|
||
- GUI interaction was not exercised in this headless environment, but the feature logic and build integration were reviewed successfully.
|
||
</previous_issue_solution>
|
||
<previous_issue>
|
||
## Plan Task
|
||
Make it so when you click a connect planet system via the selector, it selects it.
|
||
Make it so you can drag click to select multiple planets.
|
||
Remove the y 0 boundary. I want to be able to drag it anywhere.
|
||
</previous_issue>
|
||
<previous_issue_solution>
|
||
tool name: submit
|
||
tool parameters:
|
||
</previous_issue_solution>
|
||
</plan_session_history> |